[
https://issues.apache.org/jira/browse/PHOENIX-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032996#comment-15032996
]
James Taylor commented on PHOENIX-2374:
---------------------------------------
Got time for a quick review, [~samarthjain]? I noticed this a few weeks back
but wanted to wait to fix it until after transactions were merged.
> Honor PTable.isWALDisabled() for row deletes
> --------------------------------------------
>
> Key: PHOENIX-2374
> URL: https://issues.apache.org/jira/browse/PHOENIX-2374
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Attachments: PHOENIX-2374.patch
>
>
> Just noticed this incorrect code in PTableImpl.PRowImpl.delete():
> {code}
> @Override
> public void delete() {
> newMutations();
> Delete delete = new Delete(key);
> for (PColumnFamily colFamily : families) {
> delete.deleteFamily(colFamily.getName().getBytes(), ts);
> }
> deleteRow = delete;
> // No need to write to the WAL for indexes
> if (PTableImpl.this.getType() == PTableType.INDEX) {
> deleteRow.setDurability(Durability.SKIP_WAL);
> }
> }
> {code}
> We shouldn't special case indexes, but just use the standard isWALDisabled()
> check here like this:
> {code}
> @Override
> public void delete() {
> newMutations();
> Delete delete = new Delete(key);
> for (PColumnFamily colFamily : families) {
> delete.deleteFamily(colFamily.getName().getBytes(), ts);
> }
> deleteRow = delete;
> if (PTableImpl.this.isWALDisabled()) {
> deleteRow.setDurability(Durability.SKIP_WAL);
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
