[
https://issues.apache.org/jira/browse/PHOENIX-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034681#comment-15034681
]
James Taylor commented on PHOENIX-2458:
---------------------------------------
Patch looks to be a big improvement. One question: did you derive a couple of
these from BaseOwnClusterIT instead of BaseOwnClusterHBaseManagedTimeIT on
purpose and if so can you please add a code comment on why? If not,
BaseOwnClusterHBaseManagedTimeIT would be preferable - the difference being
that it deletes any tables that were created from prior tests.
> Refactoring tests that start the txn manager to use BaseOwnClusterIT
> ---------------------------------------------------------------------
>
> Key: PHOENIX-2458
> URL: https://issues.apache.org/jira/browse/PHOENIX-2458
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Attachments: PHOENIX-2458-v2.patch, PHOENIX-2458.patch
>
>
> Also make setupTxManager private.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
