Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/141#issuecomment-161471331
Awesome, @ndimiduk - I love it. Couple of questions and some nits:
- For JSON, is only single level supported? If not, how is nested JSON
handled?
- Looks like lists are converted into ARRAYs which is nice. What happens if
the array elements have different data types? I guess you'd just log an error
and ignore that row?
- Can you make sure the indenting conforms to the 4 space convention?
- Also, please make sure imports don't use * and that their order is
correct (see dev/phoenix.importorder and dev/eclipse_prefs_phoenix.epf).
@gabrielreid - got a few spare cycles for a review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
