[
https://issues.apache.org/jira/browse/PHOENIX-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047253#comment-15047253
]
Hadoop QA commented on PHOENIX-2496:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12776355/PHOENIX-2496-1.patch
against master branch at commit 578979a1437124d53e319ad554b72793bcef6fd3.
ATTACHMENT ID: 12776355
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
34 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.hbase.index.covered.example.EndToEndCoveredIndexingIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.mapreduce.CsvBulkLoadToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.AlterTableWithViewsIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/195//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/195//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/195//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/195//console
This message is automatically generated.
> ShutdownHook preventing JVM from exiting after SIGTERM
> ------------------------------------------------------
>
> Key: PHOENIX-2496
> URL: https://issues.apache.org/jira/browse/PHOENIX-2496
> Project: Phoenix
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: 4.7.0
>
> Attachments: PHOENIX-2496-1.patch, PHOENIX-2496.patch
>
>
> [~cartershanklin] pointed out to me that he got into a case where sending a
> SIGTERM to the Phoenix QueryServer resulted in it not exiting. I've been able
> to reproduce this.
> 1. Start HBase and PQS
> 2. Stop HBase master
> 3. Try to run a query through PQS
> 4. {{kill -15 <pqs_pid>}}
> At this point, the thread from #3 is still running in PQS, trying to connect
> to HBase (following the normal HBase retry policy which will retry for
> order-minutes). The ShutdownHook, run as an attempt to cleanup nicely, gets
> blocked trying to close the instance because the read lock is still held by
> the step 3 query. The outward effect is that PQS stays up and running until
> HBase becomes available or the HBase retries time out because the JVM will
> stay running until all shutdown hooks return.
> While the system will eventually fix itself, it's a bit awkward to send
> SIGTERM to a process and not have it die within a few seconds. The code
> around the shutdown hook registration certainly seems like blocking is
> unintentional too.
> A simple fix is to wrap the PhoenixDriver closing in a timeout so that we
> don't rely on the HBase timeout to exit the JVM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
