[
https://issues.apache.org/jira/browse/PHOENIX-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059030#comment-15059030
]
Josh Elser commented on PHOENIX-2528:
-------------------------------------
Hi [[email protected]]. Thanks for taking a look!
bq. Instead of adding a shutdown method, can you just add the pool shutdown to
the complete() method provided by the interface
Oh, sure. I missed that the first time around :)
bq. Also, I know it's pre existing, but it would be cool to change the call to
go through the interface instead of the instance as well.
Simple enough, too.
Let me get a new patch up here.
> Pherf JVM doesn't exit due to un-closed ThreadPool
> --------------------------------------------------
>
> Key: PHOENIX-2528
> URL: https://issues.apache.org/jira/browse/PHOENIX-2528
> Project: Phoenix
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: 4.7.0
>
> Attachments: PHOENIX-2528.patch
>
>
> In trying to use the pherf tool in "cluster" mode, the invocation of
> {{Pherf}} never exited. I had removed a {{System.exit(0)}} already because it
> was suppressing an Exception.
> The JVM never exited because there were a number of threads (8) still running
> and not marked as daemon. After a while, I finally tracked down these threads
> to {{WriteWorkload}} which didn't bother to close the pool.
> I believe the System.exit was forcing the JVM to exit instead of letting it
> exit naturally.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
