[
https://issues.apache.org/jira/browse/PHOENIX-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065650#comment-15065650
]
Gabriel Reid commented on PHOENIX-2538:
---------------------------------------
Looks ok to me, just two things that I noticed:
* the checking for success on the delete of the output directory (and logging
if it fails) has been removed -- is there a reason for this? Seems better to
leave this in.
* the order of imports has gotten changed around quite a bit, is that because
it was wrong before, or is this patch doing the imports in the incorrect order?
> CsvBulkLoadTool should return non-zero exit status if import fails
> ------------------------------------------------------------------
>
> Key: PHOENIX-2538
> URL: https://issues.apache.org/jira/browse/PHOENIX-2538
> Project: Phoenix
> Issue Type: Bug
> Reporter: Gabriel Reid
> Assignee: maghamravikiran
> Fix For: 4.7.0
>
> Attachments: PHOENIX-2538.patch
>
>
> The changes in PHOENIX-2216 accidentally changed CsvBulkLoadTool so that it
> does not correctly return a non-zero error code if the import job fails. This
> makes it impossible for users of the tool to automatically determine if the
> tool failed (e.g. when running it from shell scripts).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
