[ 
https://issues.apache.org/jira/browse/PHOENIX-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15086412#comment-15086412
 ] 

James Taylor commented on PHOENIX-2570:
---------------------------------------

Patch looks good, but wouldn't it be the same to do this where it was done 
before (with this new if statement)?
{code}
+            if (clientProps.getBoolean(QueryServices.TRANSACTIONS_ENABLED, 
QueryServicesOptions.DEFAULT_TRANSACTIONS_ENABLED)) {
+                setupTxManager();
+            }
{code}

> Start transaction manager only when needed and reduce number of threads 
> spawned for tests
> -----------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-2570
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2570
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-2570_4.x-HBase-0.98.patch, 
> PHOENIX-2570_4.x-HBase-0.98_v2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to