[
https://issues.apache.org/jira/browse/PHOENIX-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095630#comment-15095630
]
James Taylor commented on PHOENIX-2368:
---------------------------------------
[~samarthjain] - just a thought, but it'd be good to have the public close
method also deregister the driver and set the static INSTANCE member to null
(and yes, we'd need to not make it final any longer). Otherwise, once you do a
close on PhoenixDriver, you can't use Phoenix from that JVM anymore.
Thoughts?
> Call Driver.accept() in Driver.getConnection and return null if false
> ---------------------------------------------------------------------
>
> Key: PHOENIX-2368
> URL: https://issues.apache.org/jira/browse/PHOENIX-2368
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: ramkrishna.s.vasudevan
> Labels: SFDC, newbie
> Fix For: 4.7.0
>
> Attachments: PHOENIX-2368.patch, PHOENIX-2368.patch,
> PHOENIX-2368_1.patch
>
>
> The driver should return "null" if it realizes it is the wrong kind of driver
> to connect to the given URL.
> Your driver is throwing an exception instead of returning null.
> Here's the start of a test case:
> {code}
> public static void main(String[] args) throws Exception {
> Class.forName(PhoenixDriver.class.getName());
> PhoenixDriver d = (PhoenixDriver) DriverManager.getDriver("jdbc:phoenix");
> d.close();
> DriverManager.getConnection("any text whatever you want to put here");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
