[
https://issues.apache.org/jira/browse/PHOENIX-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15101411#comment-15101411
]
Alicia Ying Shu edited comment on PHOENIX-2221 at 1/15/16 8:52 AM:
-------------------------------------------------------------------
[~jamestaylor] Yes. There could be race condition. Multiple PUTs (indexState
and indexDisableTimestamp) to change meta data may increase the chance.
PHOENIX-2221-v3.patch works that it only uses PIndexState.READABLE to check
whether blocking writes. I manually in debugger verified that it would block
writes. IMHO, we can make things simple by changing indexState to be READABLE
when index updating fails. During index repairing blocks writes if IndexState
is READABLE. Change IndexState back to ACTIVE when finishing index repair. I
can modify PHOENIX-2221-v3.patch to use the Delegate as you suggested, etc.
was (Author: aliciashu):
Yes. There could be race condition.
> Option to make data regions not writable when index regions are not available
> -----------------------------------------------------------------------------
>
> Key: PHOENIX-2221
> URL: https://issues.apache.org/jira/browse/PHOENIX-2221
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Devaraj Das
> Assignee: Alicia Ying Shu
> Fix For: 4.8.0
>
> Attachments: DelegateIndexFailurePolicy.java, PHOENIX-2221-v1.patch,
> PHOENIX-2221-v2.patch, PHOENIX-2221-v3.patch, PHOENIX-2221-v4.patch,
> PHOENIX-2221-v5.patch, PHOENIX-2221.patch, PHOENIX-2221.wip
>
>
> In one usecase, it was deemed better to not accept writes when the index
> regions are unavailable for any reason (as opposed to disabling the index and
> the queries doing bigger data-table scans).
> The idea is that the index regions are kept consistent with the data regions,
> and when a query runs against the index regions, one can be reasonably sure
> that the query ran with the most recent data in the data regions. When the
> index regions are unavailable, the writes to the data table are rejected.
> Read queries off of the index regions would have deterministic performance
> (and on the other hand if the index is disabled, then the read queries would
> have to go to the data regions until the indexes are rebuilt, and the queries
> would suffer).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
