Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/147#issuecomment-172037773
Thanks for the patch, @ankitsinghal. The main remaining issues are around
not treating an ImmutableBytesWritable the same as a byte[]. Maybe easiest for
now to have BaseResultIterators.getParallelScans() declare currentKey as an
ImmutableBytesWritable, but keep
// Do this as infrequently as possible to prevent a copy of the backing
byte array
byte[] currentKeyBytes = SchemaUtil.copyKeyIfNecessary(currentKey);
byte[] currentGuidePostBytes =
SchemaUtil.copyKeyIfNecessary(currentGuidePost);
Scan newScan = scanRanges.intersectScan(scan, currentKeyBytes,
currentGuidePostBytes, keyOffset, false);
scans = addNewScan(parallelScans, scans, newScan,
currentGuidePostBytes, false, regionLocation);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
