Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/147#discussion_r49935621
  
    --- Diff: phoenix-protocol/src/main/PTable.proto ---
    @@ -52,11 +52,12 @@ message PColumn {
     
     message PTableStats {
       required bytes key = 1;
    -  repeated bytes values = 2;
    +  optional bytes guidePosts = 2;
    --- End diff --
    
    Let's do something in-the-middle. We can stick with the plan that this is 
still 4.7.0 release, but we can do the above in MetaDataRegionObserver to 
ensure that the SYSTEM.STATS table is truncated. Here what needs to be done:
    * conditionally truncate SYSTEM.STATS table in 
MetaDataRegionObserver.postOpen() based on checkAndPut
    * keep values field at protobuf position 2 and return an empty PGuidePosts 
for that field. We'll document that stats are essentially disabled for an old 
client once you upgrade your server (but nothing will break).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to