Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/147#discussion_r50245176
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataRegionObserver.java
---
@@ -96,10 +111,109 @@ public void start(CoprocessorEnvironment env) throws
IOException {
rebuildIndexTimeInterval =
env.getConfiguration().getLong(QueryServices.INDEX_FAILURE_HANDLING_REBUILD_INTERVAL_ATTRIB,
QueryServicesOptions.DEFAULT_INDEX_FAILURE_HANDLING_REBUILD_INTERVAL);
}
-
+
+ private static String getJdbcUrl(RegionCoprocessorEnvironment env) {
+ String zkQuorum =
env.getConfiguration().get(HConstants.ZOOKEEPER_QUORUM);
+ String zkClientPort =
env.getConfiguration().get(HConstants.ZOOKEEPER_CLIENT_PORT,
+ Integer.toString(HConstants.DEFAULT_ZOOKEPER_CLIENT_PORT));
+ String zkParentNode =
env.getConfiguration().get(HConstants.ZOOKEEPER_ZNODE_PARENT,
+ HConstants.DEFAULT_ZOOKEEPER_ZNODE_PARENT);
+ return PhoenixRuntime.JDBC_PROTOCOL +
PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkQuorum
+ + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkClientPort
+ + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkParentNode;
+ }
@Override
public void postOpen(ObserverContext<RegionCoprocessorEnvironment> e) {
+ final RegionCoprocessorEnvironment env = e.getEnvironment();
+
+ Runnable r = new Runnable() {
+ @Override
+ public void run() {
+ HTableInterface metaTable = null;
+ HTableInterface statsTable = null;
+ try {
+ Thread.sleep(1000);
+ LOG.info("Stats will be deleted for upgrade 4.7
requirement!!");
+ metaTable =
env.getTable(TableName.valueOf(PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME));
+ List<Cell> columnCells = metaTable
+ .get(new Get(SchemaUtil.getTableKey(null,
PhoenixDatabaseMetaData.SYSTEM_SCHEMA_NAME,
+
PhoenixDatabaseMetaData.SYSTEM_CATALOG_TABLE)))
+
.getColumnCells(PhoenixDatabaseMetaData.TABLE_FAMILY_BYTES,
+ QueryConstants.EMPTY_COLUMN_BYTES);
+ if (!columnCells.isEmpty()
+ && columnCells.get(0).getTimestamp() <
MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP_4_7_0) {
--- End diff --
I think this is needed to prevent system.stats being deleted after the
client upgrade also as upgrade in connectionQueryServicesImpl will delete all
the rows of system.stats from catalog including the dummy column. WDYT?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
