[
https://issues.apache.org/jira/browse/PHOENIX-2612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109802#comment-15109802
]
Hadoop QA commented on PHOENIX-2612:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12783452/PHOENIX-2612.1.patch
against master branch at commit 6a27cecce312002f9b7f76ffdcafcb694f5e3ea8.
ATTACHMENT ID: 12783452
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 8 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
33 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public static final String TEST_SCENARIO_ROOT_PATTERN = ".*" + "test"
+ "_" + PherfConstants.RESOURCE_SCENARIO.substring(1);
+ assertResources(PherfConstants.TEST_SCENARIO_ROOT_PATTERN + extension,
PherfConstants.RESOURCE_SCENARIO, extension);
+ private static final String matcherScenario =
PherfConstants.TEST_SCENARIO_ROOT_PATTERN + ".xml";
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/231//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/231//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/231//console
This message is automatically generated.
> Pherf - RuleGeneartor test in phoenix-pherf passes and fails in different
> environments.
> -----------------------------------------------------------------------------------------
>
> Key: PHOENIX-2612
> URL: https://issues.apache.org/jira/browse/PHOENIX-2612
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.6.0
> Reporter: Karan Singhal
> Assignee: Karan Singhal
> Labels: Performance
> Fix For: 4.6.0, 4.7.0
>
> Attachments: PHOENIX-2612.1.patch, PHOENIX-2612.patch
>
>
> This is happening because regex used in test for searching path of
> test-scenario.xml is not specific. The pattern being used is
> *scenario.*scenario.*.xml due to which pattern matcher finds all the
> different xmls in the package. After that all the xml's are parsed if
> pattern matcher finds test-scenario.xml in path first then test-scenario.xml
> is parsed first and test passes because test is always reading datamodel at
> index 0 (hard coded in test) from list of datamodels and if any other xml is
> parsed first it fails because it did not get right datamodel.
> Solution is simple just make matcher scenario in test to be more specific so
> that every time test-scenario.xml is picked up. After looking at some other
> tests I found .*test_scenario.xml is used in lot of other tests which is the
> most appropriate for searching test_sceanario.xml and can be used for this
> test too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
