[ 
https://issues.apache.org/jira/browse/PHOENIX-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122010#comment-15122010
 ] 

James Taylor commented on PHOENIX-1849:
---------------------------------------

+1 with one very minor formatting nit. Remove the semicolon in the try and add 
a space, like this:
{code}
       try (PreparedStatement colUpsert = 
connection.prepareStatement(upsertStatement)) {
{code}

Please commit to 4.x and master branches. Thanks for the contribution, 
[~maghamravikiran].

> MemoryLeak in PhoenixFlumePlugin PhoenixConnection
> --------------------------------------------------
>
>                 Key: PHOENIX-1849
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1849
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.3.0
>         Environment: JDK 1.7 Flume 1.5.2 Phoenix 4.3.0 HBase 0.98
>            Reporter: PeiLiping
>            Assignee: maghamravikiran
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-1849.patch
>
>
> I got OOME after using the PhoenixFlumePlugin to write data into HBase for 6 
> hours. It looks like the  PhoenixConnection never release the prepare 
> statements list even I call the commit method manually. 
> Now I had to close the connection after using the connection thousand times 
> and recreate a new connection later.
> This issue is caused by the statements is never be cleared, so the fix could 
> be clear the statements once the connection doesn't need them.
> Code:
> PhoenixConnection.java : 122 
> private List<SQLCloseable> statements = new ArrayList<SQLCloseable>();



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to