[ https://issues.apache.org/jira/browse/PHOENIX-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140039#comment-15140039 ]
Hadoop QA commented on PHOENIX-2602: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12787157/PHOENIX-2602-4.x-HBase-0.98.patch against 4.x-HBase-0.98 branch at commit c485a40c766e34e3a5a443e60057cfaa1cb92869. ATTACHMENT ID: 12787157 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/249//console This message is automatically generated. > Parser does not handle escaped LPAREN > ------------------------------------- > > Key: PHOENIX-2602 > URL: https://issues.apache.org/jira/browse/PHOENIX-2602 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.6.0 > Reporter: Nick Dimiduk > Assignee: Thomas D'Silva > Fix For: 4.7.0 > > Attachments: PHOENIX-2602-4.x-HBase-0.98.patch > > > Seems parsing string literals isn't working quite right. > {noformat} > 0: jdbc:phoenix:localhost> explain select foo from bar where foo not like > '%\(%' ; > line 1:50 no viable alternative at character '(' > Error: ERROR 602 (42P00): Syntax error. Missing "LPAREN" at line 1, column > 35. (state=42P00,code=602) > org.apache.phoenix.exception.PhoenixParserException: ERROR 602 (42P00): > Syntax error. Missing "LPAREN" at line 1, column 35. > at > org.apache.phoenix.exception.PhoenixParserException.newException(PhoenixParserException.java:33) > at > org.apache.phoenix.parse.SQLParser.parseStatement(SQLParser.java:111) > at > org.apache.phoenix.jdbc.PhoenixStatement$PhoenixStatementParser.parseStatement(PhoenixStatement.java:1285) > at > org.apache.phoenix.jdbc.PhoenixStatement.parseStatement(PhoenixStatement.java:1366) > at > org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:1429) > at sqlline.Commands.execute(Commands.java:822) > at sqlline.Commands.sql(Commands.java:732) > at sqlline.SqlLine.dispatch(SqlLine.java:808) > at sqlline.SqlLine.begin(SqlLine.java:681) > at sqlline.SqlLine.start(SqlLine.java:398) > at sqlline.SqlLine.main(SqlLine.java:292) > Caused by: MissingTokenException(inserted [@-1,0:0='<missing > LPAREN>',<90>,1:34] at foo) > at > org.apache.phoenix.parse.PhoenixSQLParser.recoverFromMismatchedToken(PhoenixSQLParser.java:350) > at org.antlr.runtime.BaseRecognizer.match(BaseRecognizer.java:115) > at > org.apache.phoenix.parse.PhoenixSQLParser.not_expression(PhoenixSQLParser.java:6463) > at > org.apache.phoenix.parse.PhoenixSQLParser.and_expression(PhoenixSQLParser.java:6283) > at > org.apache.phoenix.parse.PhoenixSQLParser.or_expression(PhoenixSQLParser.java:6220) > at > org.apache.phoenix.parse.PhoenixSQLParser.expression(PhoenixSQLParser.java:6185) > at > org.apache.phoenix.parse.PhoenixSQLParser.single_select(PhoenixSQLParser.java:4388) > at > org.apache.phoenix.parse.PhoenixSQLParser.unioned_selects(PhoenixSQLParser.java:4470) > at > org.apache.phoenix.parse.PhoenixSQLParser.select_node(PhoenixSQLParser.java:4535) > at > org.apache.phoenix.parse.PhoenixSQLParser.oneStatement(PhoenixSQLParser.java:766) > at > org.apache.phoenix.parse.PhoenixSQLParser.explain_node(PhoenixSQLParser.java:987) > at > org.apache.phoenix.parse.PhoenixSQLParser.oneStatement(PhoenixSQLParser.java:946) > at > org.apache.phoenix.parse.PhoenixSQLParser.statement(PhoenixSQLParser.java:500) > at > org.apache.phoenix.parse.SQLParser.parseStatement(SQLParser.java:108) > ... 9 more > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)