[
https://issues.apache.org/jira/browse/PHOENIX-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159938#comment-15159938
]
Hudson commented on PHOENIX-2707:
---------------------------------
SUCCESS: Integrated in Phoenix-master #1155 (See
[https://builds.apache.org/job/Phoenix-master/1155/])
PHOENIX-2707 Differentiate between a table+family have zero guideposts
(jtaylor: rev c25f88791c86cd65ea21810406eec199403d78aa)
* phoenix-core/src/main/java/org/apache/phoenix/schema/stats/StatisticsUtil.java
*
phoenix-core/src/main/java/org/apache/phoenix/schema/stats/PTableStatsImpl.java
* phoenix-core/src/main/java/org/apache/phoenix/util/PrefixByteCodec.java
* phoenix-core/src/main/java/org/apache/phoenix/schema/stats/GuidePostsInfo.java
* phoenix-core/src/it/java/org/apache/phoenix/end2end/MutableIndexToolIT.java
* phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java
*
phoenix-core/src/it/java/org/apache/phoenix/end2end/StatsCollectionDisabledIT.java
* phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java
*
phoenix-core/src/main/java/org/apache/phoenix/schema/stats/DefaultStatisticsCollector.java
*
phoenix-core/src/main/java/org/apache/phoenix/schema/stats/StatisticsWriter.java
* phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
* phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java
* phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
* phoenix-core/src/test/java/org/apache/phoenix/query/QueryServicesTestImpl.java
* phoenix-core/src/it/java/org/apache/phoenix/end2end/StatsCollectorIT.java
*
phoenix-core/src/main/java/org/apache/phoenix/schema/stats/GuidePostsInfoBuilder.java
> Differentiate between a table+family have zero guideposts from not having
> collected guideposts
> ----------------------------------------------------------------------------------------------
>
> Key: PHOENIX-2707
> URL: https://issues.apache.org/jira/browse/PHOENIX-2707
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Attachments: PHOENIX-2707.patch, PHOENIX-2707_v2.patch,
> PHOENIX-2707_v3.patch
>
>
> In order to accurately track the rows and bytes being scanned, we need to be
> able to differentiate between a table+family have zero guideposts from not
> having collected guideposts. See PHOENIX-2706 which attempted to do the same,
> but in a limited/broken way.
> This new approach will do the following instead:
> - in DefaultStatisticsCollector.writeStatsToStatsTable(), if there are no
> stats to write, write a row with the physicalTable+columnFamily for the row
> key and a byteCount and rowCount of zero (in addition to what's being done
> now).
> - otherwise, always write a Delete for the physicalTable+columnFamily row. In
> this way, only if all regions of a given column family have no guideposts,
> will this row remain.
> - in StatisticsWriter.deleteStats(), always write a Delete marker for the
> physicalTable+columnFamily row.
> - in BaseResultIterators.getParallelScans(), set the areStatsEnabled to true
> or false based on gps==GuidePostsInfo.EMPTY_GUIDEPOST. In the case of having
> no rows, the getGuidePosts() method would return a different GuidePostsInfo
> (that indicates there are no rows).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
