[
https://issues.apache.org/jira/browse/PHOENIX-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180409#comment-15180409
]
James Taylor edited comment on PHOENIX-331 at 3/4/16 7:30 PM:
--------------------------------------------------------------
Thanks for picking up this important work, [~sergey.soldatov]. There still
appears to be a fair amount of copy/paste code from our MR integration. For
example:
- HivePhoenixInputFormat extends PhoenixInputFormat but seems to copy/paste
much of the code. Is that necessary? Can some refactoring be done instead?
- Same thing with HivePhoenixRecordReader which extends PhoenixRecordReader.
[~maghamravikiran], [~ndimiduk, and [~gabriel.reid] - would be great if you
could review.
was (Author: jamestaylor):
Thanks for picking up this important work, [~sergey.soldatov]. There still
appears to be a fair amount of copy/paste code from our MR integration. For
example:
- HivePhoenixInputFormat extends PhoenixInputFormat but seems to copy/paste
much of the code. Is that necessary? Can some refactoring be done instead?
- Same thing with HivePhoenixRecordReader which extends PhoenixRecordReader.
[~maghamravikiran] & [~ndimiduk] - would be great if you could review.
> Hive Storage
> ------------
>
> Key: PHOENIX-331
> URL: https://issues.apache.org/jira/browse/PHOENIX-331
> Project: Phoenix
> Issue Type: Task
> Reporter: nicolas maillard
> Labels: enhancement
> Attachments: PHOENIX-331-1.patch, PHOENIX-331.patch
>
>
> I see a pig storage has been added it would be a great feature for a hive one
> as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
