[ 
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195333#comment-15195333
 ] 

Ankit Singhal commented on PHOENIX-1311:
----------------------------------------

Thanks [~samarthjain] for the review comments. I'll incorporate them and look 
forward for more comments.
bq. Is this change needed in IndexIT.java
{code}
props.put(QueryServices.IS_NAMESPACE_MAPPING_ENABLED, Boolean.toString(true));
{code}
No , it is not needed , I'll enable this for some test to check whether 
namespaces and indexes are getting created properly.

bq. Make sure your code is formatted and coding guidelines followed. I see 
wrong indentation, missing spaces, etc. in several places.
Please ignore formatting for now, I'll do it during rebasing of the patch.

> HBase namespaces surfaced in phoenix
> ------------------------------------
>
>                 Key: PHOENIX-1311
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1311
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: nicolas maillard
>            Assignee: Ankit Singhal
>            Priority: Minor
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-1311.docx, PHOENIX-1311_v1.patch, 
> PHOENIX-1311_wip.patch, PHOENIX-1311_wip_2.patch
>
>
> Hbase (HBASE-8015) has the concept of namespaces in the form of 
> myNamespace:MyTable it would be great if Phoenix leveraged this feature to 
> give a database like feature on top of the table.
> Maybe to stay close to Hbase it could also be a create DB:Table...
> or DB.Table which is a more standard annotation?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to