Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57372367
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -3301,4 +3356,86 @@ private PTable getParentOfView(PTable view) throws
SQLException {
String parentName =
SchemaUtil.normalizeFullTableName(select.getFrom().toString().trim());
return connection.getTable(new PTableKey(view.getTenantId(),
parentName));
}
+
+ public MutationState createSchema(CreateSchemaStatement create) throws
SQLException {
+ boolean wasAutoCommit = connection.getAutoCommit();
+ connection.rollback();
+ try {
+ boolean isIfNotExists = create.isIfNotExists();
+ PSchema schema = new PSchema(create.getSchemaName());
+ connection.setAutoCommit(false);
+ List<Mutation> schemaMutations;
+
+ try (PreparedStatement schemaUpsert =
connection.prepareStatement(CREATE_SCHEMA)) {
+ schemaUpsert.setString(1, schema.getSchemaName());
+ schemaUpsert.setString(2, MetaDataClient.EMPTY_TABLE);
+ schemaUpsert.execute();
+ schemaMutations =
connection.getMutationState().toMutations(null).next().getSecond();
+ connection.rollback();
+ }
+ MetaDataMutationResult result =
connection.getQueryServices().createSchema(schemaMutations,
+ schema.getSchemaName());
+ MutationCode code = result.getMutationCode();
+ switch (code) {
+ case SCHEMA_ALREADY_EXISTS:
+ if (result.getTable() != null) { // Can happen for
transactional table that already exists as HBase
--- End diff --
result.getSchema() ? Also, please remove the comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
