Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/153#discussion_r57606218
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
 ---
    @@ -1562,7 +1678,7 @@ private MetaDataMutationResult doDropTable(byte[] 
key, byte[] tenantId, byte[] s
                 }
     
                 if (tableType != PTableType.VIEW) { // Add to list of HTables 
to delete, unless it's a view
    -                tableNamesToDelete.add(table.getName().getBytes());
    +                tableNamesToDelete.add(table.getPhysicalName().getBytes());
    --- End diff --
    
    There seems to be a lot of these changes of getName to getPhysicalName 
which I don't believe is correct. The getName() returns the logical name while 
getPhysicalName() returns the physical table name. Why was this change made?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to