[ https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219218#comment-15219218 ]
ASF GitHub Bot commented on PHOENIX-2722: ----------------------------------------- Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/154#discussion_r57993856 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java --- @@ -241,7 +241,7 @@ public void testDerivedTableWithWhere() throws Exception { rs = statement.executeQuery(); assertFalse(rs.next()); - // (offset) where + // (where offset) --- End diff -- Guess it doesn't make too much sense here to keep this (where offset) case. You can simply remove it, or otherwise, make it "(where) offset" which is essentially the same as (where offset) but is more meaningful for testing query flattening. > support mysql "limit,offset" clauses > ------------------------------------- > > Key: PHOENIX-2722 > URL: https://issues.apache.org/jira/browse/PHOENIX-2722 > Project: Phoenix > Issue Type: New Feature > Reporter: Ankit Singhal > Assignee: Ankit Singhal > Priority: Minor > Attachments: PHOENIX-2722.patch, PHOENIX-2722_formatted.patch > > > For serial query(query with “serial" hint or “limit" without "order by”), we > can limit each scan(using page filter) to “limit+offset” instead of limit > earlier. > And then, for all queries, we can forward the relevant client iterators to > the offset provided and then return the result. > syntax > {code} > [ LIMIT { count } ] > [ OFFSET start [ ROW | ROWS ] ] > [ FETCH { FIRST | NEXT } [ count ] { ROW | ROWS } ONLY ] > {code} > Some new keywords(OFFSET,FETCH,ROW, ROWS,ONLY) are getting introduced so > users might need to see that they are not using them as column name or > something. > WDYT, [~jamestaylor] -- This message was sent by Atlassian JIRA (v6.3.4#6332)