Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/154#discussion_r58558564
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/compile/SubselectRewriter.java ---
    @@ -188,6 +190,13 @@ private SelectStatement flatten(SelectStatement 
select, SelectStatement subselec
                 }
             }
             
    +        OffsetNode offset = select.getOffset();
    +        if (offsetRewrite != null || (limitRewrite != null & offset != 
null)) {
    --- End diff --
    
    Based on this not being caught by one of your new unit tests, I'd say that 
there's likely a hole in the test coverage. Would you mind adding a unit test 
that would have caught this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to