[ 
https://issues.apache.org/jira/browse/PHOENIX-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233225#comment-15233225
 ] 

James Taylor commented on PHOENIX-2156:
---------------------------------------

Awesome job, [~tdsilva]. One question: for AlterTableIT and 
AlterTableWithViewsIT, is it necessary to set DROP_METADATA_ATTRIB to true? If 
so, would it be possible to just move the tests that need this to a new test 
file? The reason is that it'll really impact how long it takes to run these 
tests.

> Support drop of column from table with views
> --------------------------------------------
>
>                 Key: PHOENIX-2156
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2156
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Assignee: Thomas D'Silva
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2156-v2.patch, PHOENIX-2156-v3.patch, 
> PHOENIX-2156.patch
>
>
> Much like PHOENIX-1504 allows a column to be added to a base view, we should 
> support dropping a column from a table that has views as well. These seems 
> like a simpler problem: you just need to query for all views with a 
> BASE_COLUMN_COUNT < dropped_column_ordinal_pos, decrement the ordinal 
> positions of columns after that, and drop indexes that reference the column 
> being dropped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to