[ 
https://issues.apache.org/jira/browse/PHOENIX-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259277#comment-15259277
 ] 

Hadoop QA commented on PHOENIX-2858:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12800908/PHOENIX-2858-v1.patch
  against master branch at commit 13aaf89540d9c2b576278fb82769c56d5e9792e4.
  ATTACHMENT ID: 12800908

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
26 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 4 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +            stmt.execute("CREATE TABLE " + transactTableName + " (k 
VARCHAR PRIMARY KEY, v1 VARCHAR, v2 VARCHAR) " +
+            stmt2.execute("CREATE TABLE " + nonTransactTableName + "(k VARCHAR 
PRIMARY KEY, v1 VARCHAR, v2 VARCHAR) ");

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-flume/target/failsafe-reports/TEST-org.apache.phoenix.flume.PhoenixSinkIT
./phoenix-flume/target/failsafe-reports/TEST-org.apache.phoenix.flume.RegexEventSerializerIT

     {color:red}-1 core zombie tests{color}.  There are 5 zombie test(s):       
at 
org.apache.phoenix.end2end.IndexToolIT.testSecondaryIndex(IndexToolIT.java:162)

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/308//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/308//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/308//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/308//console

This message is automatically generated.

> Add 'Transactional' as a column in the JDBC table metadata
> ----------------------------------------------------------
>
>                 Key: PHOENIX-2858
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2858
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.7.0, 4.8.0
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2858-v1.patch, PHOENIX-2858.patch
>
>
> Transactions were added in Phoenix 4.7, which added a column to 
> SYSTEM.CATALOG to indicate whether a table was transactional or not. While 
> this property can be accessed on PTable, the JDBC metadata API does not 
> expose it. 
> This task will add this column to the query in 
> PhoenixDatabaseMetaData.getTables()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to