[
https://issues.apache.org/jira/browse/PHOENIX-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276479#comment-15276479
]
Hadoop QA commented on PHOENIX-2884:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12802989/PHOENIX-2884.patch
against master branch at commit a8a3616febaa51508e0c433c44e5b1a049a97925.
ATTACHMENT ID: 12802989
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
28 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ assertEquals("CLIENT SERIAL 1-WAY FULL SCAN OVER T_P\n" + "
SERVER FILTER BY FIRST KEY ONLY\n"
+ assertEquals("CLIENT PARALLEL 10-WAY FULL SCAN OVER T_A\n" + "
SERVER FILTER BY FIRST KEY ONLY\n"
+ + "CLIENT MERGE SORT\n" + "CLIENT OFFSET " + offset,
QueryUtil.getExplainPlan(rs));
+ assertEquals("CLIENT PARALLEL 5-WAY FULL SCAN OVER T_P\n" + "
SERVER SORTED BY [C2.V1]\n"
+ + "CLIENT MERGE SORT\n" + "CLIENT OFFSET " + offset,
QueryUtil.getExplainPlan(rs));
+ assertEquals("CLIENT PARALLEL 10-WAY FULL SCAN OVER T_A\n" + "
SERVER SORTED BY [C2.V1]\n"
+ + "CLIENT MERGE SORT\n" + "CLIENT OFFSET " + offset,
QueryUtil.getExplainPlan(rs));
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/334//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/334//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/334//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/334//console
This message is automatically generated.
> Fix EXPLAIN plan for offset on salted table
> --------------------------------------------
>
> Key: PHOENIX-2884
> URL: https://issues.apache.org/jira/browse/PHOENIX-2884
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.8.0
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Priority: Trivial
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2884.patch
>
>
> QA Romil has pointed out this.
> 1/1 EXPLAIN SELECT * FROM table OFFSET 50;
> +------------------------------------------------------------------+
> | PLAN |
> +------------------------------------------------------------------+
> | CLIENT 20-CHUNK PARALLEL 20-WAY FULL SCAN OVER TABLE_SS49DHQ49F |
> | SERVER OFFSET 50 |
> | CLIENT MERGE SORT |
> | CLIENT OFFSET 50 |
> +------------------------------------------------------------------+
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
