[ 
https://issues.apache.org/jira/browse/PHOENIX-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Taylor updated PHOENIX-2903:
----------------------------------
    Attachment: PHOENIX-2903_v2.patch

Thanks for the review, [~rajeshbabu]. I've removed the unnecessary check for 
the region being in bounds (in the postScannerOpen). I've also made it work for 
aggregation which was somewhat tricky. 

There are many times in which the NotServerRegionException is thrown outside of 
our code and reacted to by HBase which out us knowing (namely early in the scan 
processing when HRegionServer.getRegionByEncodedName() is called). To detect 
when a split occurred, I store what we set as the start row on a new attribute 
on the Scan. Then if it differs, I know HBase mucked with it. I think you have 
a somewhat similar attribute for local indexes? We need to make a pass through 
our special attributes and consolidate them, as they're kind of a mess. I don't 
know what some of them are even used for. Anything you can do to remove ones 
which are no longer used would be much appreciated (as well as combining 
existing ones).

> Handle split during scan for row key ordered aggregations
> ---------------------------------------------------------
>
>                 Key: PHOENIX-2903
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2903
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>         Attachments: PHOENIX-2903_v1.patch, PHOENIX-2903_v2.patch, 
> PHOENIX-2903_wip.patch
>
>
> Currently a hole in our split detection code



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to