[
https://issues.apache.org/jira/browse/PHOENIX-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298447#comment-15298447
]
Samarth Jain commented on PHOENIX-2903:
---------------------------------------
Patch looks good to me, [~jamestaylor].
One minor nit: instead of passing null for RegionTracker in
TableResultIterator, maybe just pass the DEFAULT_TRACKER?
One such example in PhoenixRecordReader :
{code}
+ final TableResultIterator tableResultIterator = new
TableResultIterator(queryPlan.getContext().getConnection().getMutationState(),
+ scan, readMetrics.allotMetric(SCAN_BYTES, tableName),
+ renewScannerLeaseThreshold, queryPlan,
+ MapReduceParallelScanGrouper.getInstance(), null);
{code}
You can then get rid of this check in TableResultIterator constructor:
{code}
this.tracker = tracker == null ? DEFAULT_TRACKER : tracker;
{code}
> Handle split during scan for row key ordered aggregations
> ---------------------------------------------------------
>
> Key: PHOENIX-2903
> URL: https://issues.apache.org/jira/browse/PHOENIX-2903
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: James Taylor
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2903_v1.patch, PHOENIX-2903_v2.patch,
> PHOENIX-2903_v3.patch, PHOENIX-2903_wip.patch
>
>
> Currently a hole in our split detection code
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
