[
https://issues.apache.org/jira/browse/PHOENIX-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299774#comment-15299774
]
Hadoop QA commented on PHOENIX-2901:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12805862/PHOENIX-2901.patch
against master branch at commit 10909ae502095bac775d98e6d92288c5cad9b9a6.
ATTACHMENT ID: 12805862
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
31 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ String oldSchemaName =
MetaDataUtil.getViewIndexSequenceSchemaName(PNameFactory.newName(phoenixFullTableName),
+ String newSequenceName =
MetaDataUtil.getViewIndexSequenceName(physicalName, tenantId, true);
+ + PhoenixDatabaseMetaData.SYSTEM_SEQUENCE + "
WHERE " + PhoenixDatabaseMetaData.TENANT_ID
+ + " IS NULL AND " +
PhoenixDatabaseMetaData.SEQUENCE_SCHEMA + " = '" + newSchemaName
+ + "' AND " + PhoenixDatabaseMetaData.SEQUENCE_NAME
+ "='" + newSequenceName + "'");
+ rs = phxConn.createStatement().executeQuery("SELECT " +
PhoenixDatabaseMetaData.SEQUENCE_SCHEMA + ","
+ + PhoenixDatabaseMetaData.SEQUENCE_SCHEMA + "," +
PhoenixDatabaseMetaData.CURRENT_VALUE + " FROM "
+ + PhoenixDatabaseMetaData.SYSTEM_SEQUENCE + " WHERE " +
PhoenixDatabaseMetaData.TENANT_ID
+ + " IS NULL AND " +
PhoenixDatabaseMetaData.SEQUENCE_SCHEMA + " = '" + oldSchemaName + "'");
+ public static ColumnResolver getResolverForSchema(String schema,
PhoenixConnection connection) throws SQLException {
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/362//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/362//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/362//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/362//console
This message is automatically generated.
> If namespaces are enabled, check for existence of schema when sequence created
> ------------------------------------------------------------------------------
>
> Key: PHOENIX-2901
> URL: https://issues.apache.org/jira/browse/PHOENIX-2901
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.8.0
> Reporter: James Taylor
> Assignee: Ankit Singhal
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2901.patch
>
>
> If namespaces are enabled, we should check for the existence of the sequence
> schema before creating the sequence. There are some sequences that are
> generated by Phoenix to manage indexes over views which auto generate a
> schema name. Perhaps it'd be better if those used the SYSTEM schema instead
> and prepended the sequence name with the previous schema name to ensure
> uniqueness.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
