[
https://issues.apache.org/jira/browse/PHOENIX-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303764#comment-15303764
]
Hadoop QA commented on PHOENIX-2886:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12806582/PHOENIX-2886-v4.patch
against master branch at commit c2bb3c38e73a34f2097e6dd07eff388a22149bbc.
ATTACHMENT ID: 12806582
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
31 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ String ddl = "create table person ( id bigint not null primary
key, firstname varchar(10)," +
+ String ddl = "create table person ( id bigint not null primary key
desc, firstname char(10)," +
+ String query = "select id, 'baa' firstname, lastname from user union
all select * from person";
+ throw new
SQLExceptionInfo.Builder(SQLExceptionCode.SELECT_COLUMN_NUM_IN_UNIONALL_DIFFS)
+ throw new
SQLExceptionInfo.Builder(SQLExceptionCode.SELECT_COLUMN_TYPE_IN_UNIONALL_DIFFS)
+ if (len != null && (targetTypes.get(i).getMaxLength() == null || len >
targetTypes.get(i).getMaxLength())) {
+ if (scale != null && (targetTypes.get(i).getScale() == null || scale >
targetTypes.get(i).getScale())){
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/368//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/368//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/368//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/368//console
This message is automatically generated.
> Union ALL with Char column not present in the table in Query 1 but in Query
> 2 throw exception
> ----------------------------------------------------------------------------------------------
>
> Key: PHOENIX-2886
> URL: https://issues.apache.org/jira/browse/PHOENIX-2886
> Project: Phoenix
> Issue Type: Bug
> Reporter: Alicia Ying Shu
> Assignee: Alicia Ying Shu
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2886-v1.patch, PHOENIX-2886-v2.patch,
> PHOENIX-2886-v3.patch, PHOENIX-2886-v4.patch, PHOENIX-2886.patch,
> UnionAllIT.java.diff
>
>
> To reproduce:
> create table person ( id bigint not null primary key, firstname char(10),
> lastname varchar(10) );
> upsert into person values( 1, 'john', 'doe');
> upsert into person values( 2, 'jane', 'doe');
> -- fixed value for char(10)
> select id, 'foo' firstname, lastname from person union all select * from
> person;
> java.lang.RuntimeException: java.sql.SQLException: ERROR 201 (22000): Illegal
> data. Expected length of at least 106 bytes, but had 13
> -- fixed value for bigint
> select cast( 10 AS bigint) id, 'foo' firstname, lastname from person union
> all select * from person;
> java.lang.RuntimeException: java.sql.SQLException: ERROR 201 (22000): Illegal
> data. Expected length of at least 106 bytes, but had 13
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
