Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/171#discussion_r65294499
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java ---
@@ -572,11 +569,11 @@ public MappedByteBufferTupleQueue(int thresholdBytes)
{
}
@Override
- protected Comparator<MappedByteBufferSegmentQueue<Tuple>>
getSegmentQueueComparator() {
- return new Comparator<MappedByteBufferSegmentQueue<Tuple>>() {
+ protected Comparator<BufferSegmentQueue<Tuple>>
getSegmentQueueComparator() {
+ return new Comparator<BufferSegmentQueue<Tuple>>() {
@Override
- public int compare(MappedByteBufferSegmentQueue<Tuple> q1,
- MappedByteBufferSegmentQueue<Tuple> q2) {
+ public int compare(BufferSegmentQueue<Tuple> q1,
+ BufferSegmentQueue<Tuple> q2) {
return q1.index() - q2.index();
--- End diff --
Think we should eventually get rid of MappedByteBufferSegmentQueue and used
the DeferredXXX version instead. Maybe that'll also simply the level of
abstraction here. Go with the other changes first and see what you can do here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
