[ https://issues.apache.org/jira/browse/PHOENIX-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325329#comment-15325329 ]
Alicia Ying Shu commented on PHOENIX-2934: ------------------------------------------ Thanks [~jamestaylor] and [~sergey.soldatov] for reviewing the patch. {code} select cast('1234234234' as char(3)) c from p; {code} It did not check the length of the literal expression . We could check it when parsing it. It is a different issue. For the coerce expression addressed in this Jira, I have updated the patch adding UT test, modifying IT test, and cleaned up codes to reuse super class implementation. Thanks [~sergey.soldatov] for reviewing this version. > Checking a coerce expression at top level should not be necessary for Union > All query > ------------------------------------------------------------------------------------- > > Key: PHOENIX-2934 > URL: https://issues.apache.org/jira/browse/PHOENIX-2934 > Project: Phoenix > Issue Type: Bug > Reporter: Alicia Ying Shu > Assignee: Alicia Ying Shu > Attachments: PHOENIX-2934-v1.patch, PHOENIX-2934.patch > > > When working on PHOENIX-2886, found that we need special handling of coerce > expression. Otherwise the following query would fail. > {code} > create table person ( id bigint not null primary key, firstname char(10), > lastname varchar(10) ); > select id, cast( 'foo' as char(10)) firstname, lastname from person union all > select * from person; > {code} > Checking a coerce expression at top level should not be necessary. Need to > find out root cause on coerceExpression. -- This message was sent by Atlassian JIRA (v6.3.4#6332)