[ 
https://issues.apache.org/jira/browse/PHOENIX-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338811#comment-15338811
 ] 

Lars Hofhansl commented on PHOENIX-3005:
----------------------------------------

OK... The reason is this in GroupBy.compile:
{code}
            if (isOrderPreserving) {
                return new 
GroupBy.GroupByBuilder(this).setOrderPreservingColumnCount(orderPreservingColumnCount).build();
            }
            if (isUngroupedAggregate) {
                return UNGROUPED_GROUP_BY;
            }
{code}
After we return UNGROUPED_GROUP_BY there's no further optimization, obviously.
Now... Do I need this even? I moved it there from GroupByCompiler.compiler in 
order to avoid unnecessary work.


> Use DistinctPrefixFilter for COUNT(DISTINCT...) index scans
> -----------------------------------------------------------
>
>                 Key: PHOENIX-3005
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3005
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>             Fix For: 4.8.0
>
>
> Currently the optimization in PHOENIX-258 is not used for DISTINCT index 
> scans. We should add that as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to