[ 
https://issues.apache.org/jira/browse/PHOENIX-3015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343211#comment-15343211
 ] 

Hadoop QA commented on PHOENIX-3015:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12812349/PHOENIX-3015.patch
  against master branch at commit 0acabcdab9b65661fc05900ae8b2c6c4c0ae4c41.
  ATTACHMENT ID: 12812349

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
34 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/407//testReport/
Javadoc warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/407//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/407//console

This message is automatically generated.

> Any metadata changes may cause unpredictable result when local indexes are 
> using
> --------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3015
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3015
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Sergey Soldatov
>            Assignee: Sergey Soldatov
>            Priority: Critical
>         Attachments: PHOENIX-3015.patch
>
>
> The problem code is in 
> IndexHalfStoreFileReaderGenerator#preStoreFileReaderOpen:
> {noformat}
>                 conn = 
> QueryUtil.getConnection(ctx.getEnvironment().getConfiguration()).unwrap(
>                             PhoenixConnection.class);
>                 PTable dataTable = PhoenixRuntime.getTable(conn, 
> tableName.getNameAsString());
> {noformat}
> Use case:
> 1. create table & local index. Load some data.
> 2. Call split. 
> 3a. Add new local index. 
> 3b. Drop local index and recreate it.
> 4. Call split.
> When the earlier mentioned code is executed during (2) it caches table into 
> ConnectionQueryServicesImpl#latestMetaData . When it is executed during (4)  
> dataTable is getting from cache and doesn't reflect information after (3a) or 
> (3b). As the result the data for last created index will be lost during the 
> split because of absence of index maintainer.
> After looking into ConnectionQueryServicesImpl I don't understand how the 
> cache was supposed to be updated, so any suggestions/comments are really 
> appreciated. 
> [~jamestaylor], [~rajeshbabu] FYI



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to