[ 
https://issues.apache.org/jira/browse/PHOENIX-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352356#comment-15352356
 ] 

James Taylor commented on PHOENIX-3028:
---------------------------------------

+1 to the patch. We wrote the commit timestamp previously upfront to have an 
imperfect way of preventing stats from being calculated while stats collection 
is already in progress, but we don't need that anymore because of changes 
you've made a while back.

Your idea sounds good about having our own config, [~samarthjain]. You can use 
the copy constructor and then just override whatever properties needed.

> StatisticsWriter shouldn't fail compaction in case of errors
> ------------------------------------------------------------
>
>                 Key: PHOENIX-3028
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3028
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.8.0
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-3028.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to