[
https://issues.apache.org/jira/browse/PHOENIX-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355590#comment-15355590
]
Ankit Singhal commented on PHOENIX-2999:
----------------------------------------
Thanks [~jamestaylor] for the review.
bq. Rather than creating an in-memory Set (which could in theory get
arbitrarily large), how about walking through the ResultSet and calling the
upgrade util as you're iterating?
Yes, I can do that by doing ORDER BY TENANT_ID and opening connection with new
tenantId and completing the upgrade. do you see much benefit of doing it, as we
will just store views of 1 table only in a SET . I'm just worry about scanner
timeout between next call or something if upgrade takes time.
bq. there's no need for that NOT IN condition
Actually, with new local index implementation, local indexes will also have
same physical table name as data table ,so query for getting views without NOT
IN will give local index too which I don't want in upgrade code. May be
MetaDataEndPointImpl.findChildViews also needs to be updated to avoid including
local indexes.
> Upgrading Multi-tenant table to map with namespace using upgradeUtil
> --------------------------------------------------------------------
>
> Key: PHOENIX-2999
> URL: https://issues.apache.org/jira/browse/PHOENIX-2999
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.8.0
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Priority: Critical
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2999.patch, PHOENIX-2999_v1.patch,
> PHOENIX-2999_v2.patch, PHOENIX-2999_v3.patch
>
>
> currently upgradeUtil doesn't handle multi-tenant table with tenant views
> properly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
