[
https://issues.apache.org/jira/browse/PHOENIX-3055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366556#comment-15366556
]
Enis Soztutar commented on PHOENIX-3055:
----------------------------------------
bq. Though seemingly innocuous, changes like this can lead to subtle issues.
Also, adding null checks everywhere is not always necessary. I'd recommend
holding off on any changes like this this late in the game for 4.8. Would be
great if we could come up with a list of the handful of JIRAs we're targeting
for 4.8 and stick to only working on those.
Agreed, that was my concern as well. The changes for closing the statements
seems to be very low risk. I was more concerned about the closing Connection
objects from the MetaDataEndpointImp. Let's run the tests, but hold off on the
commit until after 4.8.
> Fix a few resource leaks and null dereferences reported by Coverity
> -------------------------------------------------------------------
>
> Key: PHOENIX-3055
> URL: https://issues.apache.org/jira/browse/PHOENIX-3055
> Project: Phoenix
> Issue Type: Bug
> Reporter: Alicia Ying Shu
> Assignee: Alicia Ying Shu
> Priority: Minor
> Attachments: PHOENIX-3055.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
