[
https://issues.apache.org/jira/browse/PHOENIX-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388908#comment-15388908
]
James Taylor commented on PHOENIX-3109:
---------------------------------------
Looks fine, [~samarthjain], but one nit: for a key in a map, we typically use
an ImmutableBytesPtr instead of an ImmutableBytesWritable as the former caches
the hash code while the latter would always recompute it:
{code}
+ private Map<ImmutableBytesWritable, ImmutableBytesWritable>
dataTableLocalIndexFamilyMap;
{code}
If you think this is an improvement, feel free to make this change on commit.
Would you like this in 4.8.0?
> Improve and fix the way we are caching column family names for local indexes
> in IndexMaintainer
> -----------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3109
> URL: https://issues.apache.org/jira/browse/PHOENIX-3109
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Fix For: 4.8.0
>
> Attachments: PHOENIX-3109.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
