[ https://issues.apache.org/jira/browse/PHOENIX-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394467#comment-15394467 ]
Hadoop QA commented on PHOENIX-3113: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12820227/PHOENIX-3113_test_wip.patch against master branch at commit cbc27b65d9adeeef187ec74a9654eb27f5fd965e. ATTACHMENT ID: 12820227 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+0 tests included{color}. The patch appears to be a documentation, build, or dev patch that doesn't require tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 34 warning messages. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + ddl = "CREATE " + (localIndex ? "LOCAL " : "") + "INDEX " + indexName + " ON " + fullTableName + " (decimal_pk) INCLUDE (decimal_col1, decimal_col2)" + (async ? " ASYNC" : ""); + rs = conn.getMetaData().getTables("", TestUtil.DEFAULT_SCHEMA_NAME, StringUtil.escapeLike(indexName), new String[] {PTableType.INDEX.toString()}); + if (rs.next() && PIndexState.ACTIVE.toString().equalsIgnoreCase(rs.getString(PhoenixDatabaseMetaData.INDEX_STATE))) { {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexIT {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/476//testReport/ Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/476//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/476//console This message is automatically generated. > Automatic build of async index will happen even if mapreduce.framework.name > is not set in any configuration > ----------------------------------------------------------------------------------------------------------- > > Key: PHOENIX-3113 > URL: https://issues.apache.org/jira/browse/PHOENIX-3113 > Project: Phoenix > Issue Type: Bug > Reporter: Ankit Singhal > Assignee: Loknath Priyatham Teja Singamsetty > Priority: Blocker > Fix For: 4.8.0 > > Attachments: PHOENIX-3113_test_wip.patch, phoenix-3113-v2.patch, > phoenix-3113-v3.patch, phoenix-3113.patch > > > As per below code, we are starting automatic build of async index even if > mapreduce.framework.name is not set in any of the configuration(because > conf.get(QueryServices.MAPRED_FRAMEWORK_NAME) will always return LOCAL as a > default value). > This may cause problem in the hbase cluster where mapreduce is not deployed > or this configuration is not set or included in the classpath. > {code} > String hbaseClusterDistributedMode = > conf.get(QueryServices.HBASE_CLUSTER_DISTRIBUTED_ATTRIB); > String mapredFrameworkName = > conf.get(QueryServices.MAPRED_FRAMEWORK_NAME); > if ((hbaseClusterDistributedMode != null && > !hbaseClusterDistributedMode.equals(HBASE_CLUSTER_DISTRIBUTED_CONFIG)) || > (mapredFrameworkName != null && > !mapredFrameworkName.equals(MAPRED_FRAMEWORK_YARN_CONFIG))) > { > LOG.info("Enabling Async Index rebuilder"); > AsyncIndexRebuilderTask asyncIndexRebuilderTask = new > AsyncIndexRebuilderTask(e.getEnvironment()); > // run async index rebuilder task every 10 secs to rebuild any > newly created async indexes > executor.scheduleAtFixedRate(asyncIndexRebuilderTask, 10000, > rebuildIndexTimeInterval, TimeUnit.MILLISECONDS); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)