[
https://issues.apache.org/jira/browse/PHOENIX-3120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400100#comment-15400100
]
Hadoop QA commented on PHOENIX-3120:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12821075/PHOENIX-3120-v2.patch
against master branch at commit cb21c8175534fc15f0d3934e7dd24754475c0735.
ATTACHMENT ID: 12821075
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
34 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ ddl = "CREATE " + (localIndex ? "LOCAL " : "") + "INDEX " +
indexName + " ON " + fullTableName + " (decimal_pk) INCLUDE (decimal_col1,
decimal_col2)" + (async ? " ASYNC" : "");
+ rs = conn.getMetaData().getTables("",
TestUtil.DEFAULT_SCHEMA_NAME, StringUtil.escapeLike(indexName), new String[]
{PTableType.INDEX.toString()});
+ if (rs.next() &&
PIndexState.ACTIVE.toString().equalsIgnoreCase(rs.getString(PhoenixDatabaseMetaData.INDEX_STATE)))
{
+ final PTable indexTable = PhoenixRuntime.getTable(conn,
SchemaUtil.getTableName(tableSchema, indexName));
+ final PTable dataTable = PhoenixRuntime.getTable(conn,
SchemaUtil.getTableName(tableSchema, tableName));
+ metaDataClientConn =
QueryUtil.getConnectionOnServer(props,
env.getConfiguration()).unwrap(PhoenixConnection.class);
+ LOG.info("Building Index " +
SchemaUtil.getTableName(tableSchema, indexName));
+ LOG.debug("AsyncIndexRebuilderTask can't close
metaDataClientConn", ignored);
+ public MutationState buildIndex(PTable index, TableRef dataTableRef, Long
txnScn) throws SQLException {
+ scan.setAttribute(BaseScannerRegionObserver.TX_SCN,
Bytes.toBytes(Long.valueOf(txnScn)));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MutableIndexToolIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/483//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/483//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/483//console
This message is automatically generated.
> AsyncIndexRebuilderTask fails for transactional tables
> ------------------------------------------------------
>
> Key: PHOENIX-3120
> URL: https://issues.apache.org/jira/browse/PHOENIX-3120
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.8.0
> Reporter: Thomas D'Silva
> Assignee: Thomas D'Silva
> Fix For: 4.8.1
>
> Attachments: PHOENIX-3120-v2.patch, PHOENIX-3120.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)