[
https://issues.apache.org/jira/browse/PHOENIX-3132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15402532#comment-15402532
]
ASF GitHub Bot commented on PHOENIX-3132:
-----------------------------------------
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/186
Great! I've given you karma and assigned PHOENIX-3132 to you.
> I was waiting for a response do this PR before I took on more refactoring
;)
Hah! Smart :)
> I have tested in so far as the output of the two versions of the program
are the same before they are shelled out in the last line. So, yes.
Let me clarify. I was wondering if, in your changes to be a bit more
idiomatic, you had made any changes which would help us work towards automated
unit tests which we could run during the normal Phoenix Maven build.
I've had it on my backburner to look at what Apache Ambari does to invoke
unit tests on python code and try to borrow some of that code so that we can
try to improve the quality of our python scripts and increase our confidence in
future changes (such as your's).
I don't want to push that onto you, but was just curious if you had written
any sort of tests as a part of these changes.
> cleanup sqlline-*.py using python idioms
> ----------------------------------------
>
> Key: PHOENIX-3132
> URL: https://issues.apache.org/jira/browse/PHOENIX-3132
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Pradeep Gowda
> Assignee: Pradeep Gowda
>
> Cleanup the Python program(s) to:
> 1. easier to read and modify
> 2. remove unused code and variables.
> 3. use string `format` instead of concating string using `+`s
> 4. ... and other proper Python idioms
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
