[
https://issues.apache.org/jira/browse/PHOENIX-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405033#comment-15405033
]
James Taylor commented on PHOENIX-3130:
---------------------------------------
Looks good, [~tdsilva]. Here's some feedback:
- Make sure to filter on ASYNC_CREATED_DATE in the CANDIDATE_INDEX_INFO_QUERY.
This was an important bug fix that Teja made. Compare against the current query
to ensure it's the same.
- How about naming the config {{phoenix.index.async.build.enabled}} since we
have other config properties that start with "phoenix.index" for index-related
configs?
- Then, just for consistency, ASYNC_INDEX_BUILD_ENABLED ->
INDEX_ASYNC_BUILD_ENABLED and same with default value.
> Ignore ASYNC and build indexes synchronously based on config property
> ---------------------------------------------------------------------
>
> Key: PHOENIX-3130
> URL: https://issues.apache.org/jira/browse/PHOENIX-3130
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Thomas D'Silva
> Fix For: 4.8.0
>
> Attachments: PHOENIX-3130-4.8-HBase-0.98.patch
>
>
> At test time, we want to ignore the ASYNC keyword on CREATE INDEX and instead
> just build the index synchronously. We can control this through a config
> parameter defaulted to true at test time and false otherwise.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
