[ 
https://issues.apache.org/jira/browse/PHOENIX-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410516#comment-15410516
 ] 

Sergey Soldatov commented on PHOENIX-3149:
------------------------------------------

I'm not sure whether it's showstopper. On high load clusters there is a big 
chance to get corrupted local indexes. On regular load when minor compaction is 
able to handle all flushed hfiles (so those compaction are considered as major) 
there should be a little chance to hit this problem. I may suggest that the 
check was just to be sure that this is compaction related to split, but I'm not 
sure. [~rajeshbabu] can you explain it in more details? 

> Local index got corrupted if intermediate compaction happen during the split.
> -----------------------------------------------------------------------------
>
>                 Key: PHOENIX-3149
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3149
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.8.0
>            Reporter: Sergey Soldatov
>            Assignee: Sergey Soldatov
>         Attachments: PHOENIX-3149.patch
>
>
> The scenario is quite simple: 
> If we trigger split after index creation when we have a lot of HFiles not yet 
> compacted, the compaction may happen for part of those files and the scan 
> type will be COMPACT_RETAIN_DELETES, but not COMPACT_DROP_DELETES as we 
> expect in preCompactScannerOpen. In this case the regular scanner will be 
> used during compaction and we get incorrectly data in the local index. 
> Discussed it with [~enis] offline and it seems that the check for 
> COMPACT_DROP_DELETES is not necessary and can/should be deleted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to