[ 
https://issues.apache.org/jira/browse/PHOENIX-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431880#comment-15431880
 ] 

Lars Hofhansl commented on PHOENIX-3195:
----------------------------------------

bq. DistinctPrefixFilterIT.testPlans:159->testCommonPlans:196->testPlan:210 
expected:<true> but was:<false>

Shame on me. I 99.9% sure I ran the test before I checked in.

> Slight safety improvement for using DistinctPrefixFilter
> --------------------------------------------------------
>
>                 Key: PHOENIX-3195
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3195
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Minor
>             Fix For: 4.9.0, 4.8.1
>
>         Attachments: 3195.txt
>
>
> There is a very slight improvement to when we should use the 
> DistinctPrefixFilter in its current form.
> Currently we check for the absence of WhereConditions, but what we really 
> mean to make sure that only one Cell per row is seen. Phoenix already does 
> that and used the FirstKeyOnlyFilter in that case. It's  best to use this 
> condition as well, just to be absolutely safe.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to