[
https://issues.apache.org/jira/browse/PHOENIX-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15440292#comment-15440292
]
Hadoop QA commented on PHOENIX-3036:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12825735/PHOENIX-3036_master.patch
against master branch at commit 64cb9b0130188b1407093b8bc62447bd2ecf0d3c.
ATTACHMENT ID: 12825735
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 16 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
34 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private static long getTableSequenceNumber(PhoenixConnection conn,
String tableName) throws SQLException {
+ PTable table = conn.getTable(new PTableKey(conn.getTenantId(),
SchemaUtil.normalizeIdentifier(tableName)));
+ private static short getMaxKeySequenceNumber(PhoenixConnection conn,
String tableName) throws SQLException {
+ PTable table = conn.getTable(new PTableKey(conn.getTenantId(),
SchemaUtil.normalizeIdentifier(tableName)));
+ String baseTableDDL = "CREATE TABLE " + baseTable + " (TENANT_ID
VARCHAR NOT NULL, PK1 VARCHAR NOT NULL, V1 VARCHAR, V2 VARCHAR CONSTRAINT
NAME_PK PRIMARY KEY(TENANT_ID, PK1)) MULTI_TENANT = true ";
+ + " (TENANT_ID VARCHAR NOT NULL, PK1 VARCHAR NOT NULL, V1
VARCHAR, V2 VARCHAR CONSTRAINT NAME_PK PRIMARY KEY(TENANT_ID, PK1))
MULTI_TENANT = true ";
+ // verify that the new column new_pk is now part of the primary
key for the entire hierarchy
+
assertTrue(checkColumnPartOfPk(globalConn.unwrap(PhoenixConnection.class),
"NEW_PK", baseTable));
+
assertTrue(checkColumnPartOfPk(tenant1Conn.unwrap(PhoenixConnection.class),
"NEW_PK", view1));
+
assertTrue(checkColumnPartOfPk(tenant1Conn.unwrap(PhoenixConnection.class),
"NEW_PK", view2));
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/543//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/543//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/543//console
This message is automatically generated.
> Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
> ------------------------------------------------------------------
>
> Key: PHOENIX-3036
> URL: https://issues.apache.org/jira/browse/PHOENIX-3036
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Samarth Jain
> Assignee: prakul agarwal
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3036.patch, PHOENIX-3036_4.x-HBase-1.1.patch,
> PHOENIX-3036_addendum.patch, PHOENIX-3036_master.patch, PHOENIX-3036_v2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
