Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/192#discussion_r77613518
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/util/CursorUtil.java ---
@@ -247,11 +269,11 @@ private void updateSelectValues(Tuple currentRow)
throws SQLException {
PDataType type =
projector.getExpression().getDataType();
Object value = projector.getValue(currentRow, type,
new ImmutableBytesPtr());
if(value == null){
- whereExpressionNext =
whereExpressionNext.replaceFirst(":"+Integer.toString(colBinding),"NULL");
- whereExpressionPrior =
whereExpressionPrior.replaceFirst(":"+Integer.toString(colBinding),"NULL");
+ whereExpressionNext =
whereExpressionNext.replaceFirst("::"+Integer.toString(colBinding),"NULL");
+ whereExpressionPrior =
whereExpressionPrior.replaceFirst("::"+Integer.toString(colBinding),"NULL");
} else{
- whereExpressionNext =
whereExpressionNext.replaceFirst(":"+Integer.toString(colBinding),formatString(value,
type));
- whereExpressionPrior =
whereExpressionPrior.replaceFirst(":"+Integer.toString(colBinding),formatString(value,
type));
+ whereExpressionNext =
whereExpressionNext.replaceFirst("::"+Integer.toString(colBinding),formatString(value,
type));
+ whereExpressionPrior =
whereExpressionPrior.replaceFirst("::"+Integer.toString(colBinding),formatString(value,
type));
--- End diff --
I don't think , we need to modify queries for the this support. You may
need to remove this code.(And instead of replacing why we can't use prepared
statements directly).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
