[
https://issues.apache.org/jira/browse/PHOENIX-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15475517#comment-15475517
]
James Taylor commented on PHOENIX-1367:
---------------------------------------
Looks good, [~tdsilva]. Couple of minor comments:
- Should we use a static constant prefix instead of adding the view name when
you rename? That way we can use a name that we don't allow for real indexes. We
could define something that starts with an underscore and put it in
MetaDataUtil.
- Do we need to override PTable.getParentSchemaName() and getParentTableName()
as you've done for getParentName()?
- Should we only return the physicalName when it's a view? Otherwise, I think a
regular table would return itself, no?
> VIEW derived from another VIEW doesn't use parent VIEW indexes
> --------------------------------------------------------------
>
> Key: PHOENIX-1367
> URL: https://issues.apache.org/jira/browse/PHOENIX-1367
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: Thomas D'Silva
> Fix For: 4.9.0, 4.8.1
>
> Attachments: PHOENIX-1367-4.x-HBase-0.98-v3.patch,
> PHOENIX-1369-4.x-HBase-0.98-v2.patch, PHOENIX-1369-4.x-HBase-0.98-v3.patch,
> PHOENIX-1369-4.x-HBase-0.98.patch, PHOENIX_1367.test.patch
>
>
> If a VIEW has an index and another VIEW is derived from it, the child view
> will not use the parent view's indexes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
