Github user kliewkliew commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/208#discussion_r78300203
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java
---
@@ -523,7 +523,12 @@ public Expression visitLeave(LikeParseNode node,
List<Expression> children) thro
byte[] wildcard = {StringUtil.MULTI_CHAR_LIKE};
StringUtil.fill(nullExpressionString, 0, pattern.length(),
wildcard, 0, 1, false);
if (pattern.equals(new String (nullExpressionString))) {
- return IsNullExpression.create(lhs, true,
context.getTempPtr());
--- End diff --
I made the suggested changes and added test coverage to confirm that `NULL
like '%'` returns NULL. JDBC `getBoolean` transforms NULL to false but they
provide a `wasNull` method that I used to verify the test cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
