[
https://issues.apache.org/jira/browse/PHOENIX-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15489705#comment-15489705
]
Ankit Singhal commented on PHOENIX-3237:
----------------------------------------
Thanks [~jamestaylor] for review.
bq. So essentially, each call to the method will process the indexes for one
data table, right?
yes
bq. Seems like an improvement would be to collect up Map<PTable, List<PTable>>
for the dataTable and indexesNeedingRebuilding instead of having just a single
dataTable. Otherwise, the initial scan we're running is kind of wasteful, since
it'll go through the entire SYSTEM.CATALOG table only to collect up the indexes
for a single data table. Would you mind filing a JIRA for this follow up work
or ideally just do that work here?
We anyways do scan every time to know if there are any disabled indexes.
Considering the number of dataTables returned with disabled indexes(probably
1-2 at a time), It is ok to do it for a table at a time . I think improvement
will be to do parallel rebuilds of indexes of different data tables to have
smaller indexes build first rather than waiting for another bigger rebuild to
finish.Created PHOENIX-3277 for 4.9.0
bq. +1 with one minor nit - change this so we don't allocate another String:
Will do the change and commit it now.
> Automatic rebuild of disabled index will fail if indexes of two tables are
> disabled at the same time
> ----------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3237
> URL: https://issues.apache.org/jira/browse/PHOENIX-3237
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.7.0
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Labels: index, rebuilding
> Fix For: 4.9.0, 4.8.1
>
> Attachments: PHOENIX-3237.patch
>
>
> There is a bug in automatic rebuild code where it seems to assume all
> disabled index corresponds to a single data table.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
