Hadoop QA commented on PHOENIX-3280:

{color:red}-1 overall{color}.  Here are the results of testing the latest 
  against master branch at commit 27697b364511f8557a87d4007bff1a560e4b8490.
  ATTACHMENT ID: 12828598

    {color:green}+1 @author{color}.  The patch does not contain any @author 

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
34 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +                    if ((dataTable == null || dataTable.length == 0) || 
(indexState == null || indexState.length == 0)) {
+                    if 
(Bytes.compareTo(PIndexState.DISABLE.getSerializedBytes(), indexState) == 0) {
+                        indexesToPartiallyRebuild = 
+                            LOG.info("Starting to build " + dataPTable + " 
indexes " + indexesToPartiallyRebuild
+                            try (HTableInterface dataHTable = 
conn.getQueryServices().getTable(physicalTableName)) {
+                                try (ResultScanner dataTableScanner = 
dataHTable.getScanner(dataTableScan)) {
+                                    List<Mutation> mutations = 
+                                    ImmutableBytesWritable indexMetaDataPtr = 
new ImmutableBytesWritable(
IndexMaintainer.serializeAdditional(dataPTable, indexMetaDataPtr,

     {color:red}-1 core tests{color}.  The patch failed these unit tests:

Test results: 
Release audit warnings: 
Javadoc warnings: 
Console output: 

This message is automatically generated.

> Automatic attempt to rebuild all disabled index
> -----------------------------------------------
>                 Key: PHOENIX-3280
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3280
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.9.0, 4.8.1
>         Attachments: PHOENIX-3280.patch, PHOENIX-3280_v2.patch
> Instead of only attempting to rebuild the first disabled index, we should 
> attempt to build each of them. Otherwise, a failure of the first one would 
> block the building of the others. This is follow up work for PHOENIX-3237 and 
> further improvements are identified in PHOENIX-3277.

This message was sent by Atlassian JIRA

Reply via email to