[
https://issues.apache.org/jira/browse/PHOENIX-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496816#comment-15496816
]
Kevin Liew edited comment on PHOENIX-476 at 9/16/16 6:21 PM:
-------------------------------------------------------------
Thanks for the feedback [~jamestaylor].
I attached a patch with values implemented for primary keys. The expression
node is compiled and cached in CreateTableCompiler and accessed in PTableImpl.
Will the compiled expression persist between server restarts? Do I need to
recompile the expression in MetadataClient so that the values of existing
tables are cached on server-restart?
* For non-pk columns, if we evaluate the expression once on and wrap the
column in `COALESCE` to replace `NULL` values with the expression, the user
can explicitly set values (for columns with values) to `NULL` but the values
will always be as the value. We can only make this optimization for columns
that have a `NOT NULL` constraint.
* For nullable columns and stateful default expressions (or non-literal
expressions), we will probably have to the value during the `UPSERT`
execution. In my previous patch, did I make changes in the right locations
(UpsertCompiler) for these specific cases?
was (Author: kliew):
Thanks for the feedback [~jamestaylor].
I attached a patch with default values implemented for primary keys. The
default expression node is compiled and cached in CreateTableCompiler and
accessed in PTableImpl. Will the compiled expression persist between server
restarts? Do I need to recompile the default expression in MetadataClient so
that the default values of existing tables are cached on server-restart?
* For non-pk columns, if we evaluate the default expression once on read and
wrap the column in `COALESCE` to replace `NULL` values with the default
expression, the user can explicitly set values (for columns with default
values) to `NULL` but the values will always be read as the default value. We
can only make this optimization for columns that have a `NOT NULL` constraint.
* For nullable columns and stateful default expressions, we will probably have
to store the value during the `UPSERT` execution. In my previous patch, did I
make changes in the right locations (UpsertCompiler) for these specific cases?
> Support declaration of DEFAULT in CREATE statement
> --------------------------------------------------
>
> Key: PHOENIX-476
> URL: https://issues.apache.org/jira/browse/PHOENIX-476
> Project: Phoenix
> Issue Type: Task
> Affects Versions: 3.0-Release
> Reporter: James Taylor
> Assignee: Kevin Liew
> Labels: enhancement
> Attachments: PHOENIX-476.2.patch, PHOENIX-476.patch
>
>
> Support the declaration of a default value in the CREATE TABLE/VIEW statement
> like this:
> CREATE TABLE Persons (
> Pid int NOT NULL PRIMARY KEY,
> LastName varchar(255) NOT NULL,
> FirstName varchar(255),
> Address varchar(255),
> City varchar(255) DEFAULT 'Sandnes'
> )
> To implement this, we'd need to:
> 1. add a new DEFAULT_VALUE key value column in SYSTEM.TABLE and pass through
> the value when the table is created (in MetaDataClient).
> 2. always set NULLABLE to ResultSetMetaData.columnNoNulls if a default value
> is present, since the column will never be null.
> 3. add a getDefaultValue() accessor in PColumn
> 4. for a row key column, during UPSERT use the default value if no value was
> specified for that column. This could be done in the PTableImpl.newKey method.
> 5. for a key value column with a default value, we can get away without
> incurring any storage cost. Although a little bit of extra effort than if we
> persisted the default value on an UPSERT for key value columns, this approach
> has the benefit of not incurring any storage cost for a default value.
> * serialize any default value into KeyValueColumnExpression
> * in the evaluate method of KeyValueColumnExpression, conditionally use
> the default value if the column value is not present. If doing partial
> evaluation, you should not yet return the default value, as we may not have
> encountered the the KeyValue for the column yet (since a filter evaluates
> each time it sees each KeyValue, and there may be more than one KeyValue
> referenced in the expression). Partial evaluation is determined by calling
> Tuple.isImmutable(), where false means it is NOT doing partial evaluation,
> while true means it is.
> * modify EvaluateOnCompletionVisitor by adding a visitor method for
> RowKeyColumnExpression and KeyValueColumnExpression to set
> evaluateOnCompletion to true if they have a default value specified. This
> will cause filter evaluation to execute one final time after all KeyValues
> for a row have been seen, since it's at this time we know we should use the
> default value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
